Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

binding.gyp: Use C++ 14 for Electron 11 support #17

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

DeeDeeG
Copy link

@DeeDeeG DeeDeeG commented Jul 4, 2021

Quick Summary

Electron 11 has a newer V8 engine, which apparently requires building with C++ 14 or newer.

This Pull Request bumps the C++ standard in binding.gyp so node-gyp will compile it in a way that is compatible with Electron 11.

Requirements for Contributing a Bug Fix (from template, click to expand)

Identify the Bug

Helps with atom/atom#22687, see other modules that needed this same bump: atom/atom#22687 (comment)

Description of the Change

In binding.gyp (which is read and interpreted by node-gyp), specify that compilers should use the C++ 14 standard when compiling this module's native C++ code, rather than the older C++ 11 standard that is no-longer supported in the latest V8 JS engine. Electron 11 comes with a newer V8 version.

I gathered most of this information from the comments in this issue: electron/electron#26364

Alternate Designs

We could bump to an even newer C++ standard (C++ 17, C++ 20)

Possible Drawbacks

None

Verification Process

Allows Atom CI to proceed past building this package. See my CI runs: https://dev.azure.com/DeeDeeG/b/_build?definitionId=15&_a=summary&branchFilter=182%2C182%2C182%2C182%2C182%2C182

Release Notes

Compile as C++ 14 for compatibility with Electron 11

Electron 11 has a newer V8 engine,
which apparently requires building with C++ 14 or newer.
@DeeDeeG DeeDeeG mentioned this pull request Jul 4, 2021
64 tasks
@sadick254 sadick254 merged commit 4cad48a into atom:master Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants