This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
binding.gyp: Use C++ 14 for Electron 11 support #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick Summary
Electron 11 has a newer V8 engine, which apparently requires building with C++ 14 or newer.
This Pull Request bumps the C++ standard in
binding.gyp
sonode-gyp
will compile it in a way that is compatible with Electron 11.Requirements for Contributing a Bug Fix (from template, click to expand)
Identify the Bug
Helps with atom/atom#22687, see other modules that needed this same bump: atom/atom#22687 (comment)
Description of the Change
In
binding.gyp
(which is read and interpreted bynode-gyp
), specify that compilers should use the C++ 14 standard when compiling this module's native C++ code, rather than the older C++ 11 standard that is no-longer supported in the latest V8 JS engine. Electron 11 comes with a newer V8 version.I gathered most of this information from the comments in this issue: electron/electron#26364
Alternate Designs
We could bump to an even newer C++ standard (C++ 17, C++ 20)
Possible Drawbacks
None
Verification Process
Allows Atom CI to proceed past building this package. See my CI runs: https://dev.azure.com/DeeDeeG/b/_build?definitionId=15&_a=summary&branchFilter=182%2C182%2C182%2C182%2C182%2C182
@atom/nsfw
.)Release Notes
Compile as C++ 14 for compatibility with Electron 11