This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add 2220 and 4309 to warning list #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building on win32 is failing for electron version 11.4.7. We need to add the errors on the warning list to have a passing build on atom/atom#22687 An altenative would be to fix the warnings. Right now there is no capacity for us to do the fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on win32 is failing for electron version 11.4.7. We need to add
the errors on the warning list to have a passing build on atom/atom#22687
An altenative would be to fix the warnings. Right now there is no
capacity for us to do the fixes