Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Commit

Permalink
Add 2220 and 4309 to warning list
Browse files Browse the repository at this point in the history
Building on win32 is failing for electron version 11.4.7. We need to add
the errors on the warning list to have a passing build on atom/atom#22687

An altenative would be to fix the warnings. Right now there is no
capacity for us to do the fixes
  • Loading branch information
sadick254 committed Jul 6, 2021
1 parent 23d2767 commit 3351389
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
4506, # no definition for inline function
4577, # 'noexcept' used with no exception handling mode specified; termination on exception is not guaranteed
4996, # function was declared deprecated
2220, # warning treated as error - no object file generated
4309, # 'conversion' : truncation of constant value
],
'defines': [
'_WIN32_WINNT=0x0600',
Expand Down

0 comments on commit 3351389

Please sign in to comment.