This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
drop unnecessary includes to preserve ABI compatibility #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
changed the title
shiftkey
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #268 (comment)
https://nodejs.org/dist/latest-v14.x/docs/api/n-api.html#n_api_implications_of_abi_stability indicates that including some headers may violate the ABI guarantees, and
uv.hwas included in that list. I can't spot anything obvious that uses this, so let's see if we can drop these includes to avoid any potential headaches down the track.cc @jkleinsc @vadim-termius for 馃憤 or 馃憥