Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

restore appveyor setup to use x64 version of Node #197

Merged
merged 1 commit into from Jun 27, 2019

Conversation

shiftkey
Copy link
Contributor

@shiftkey shiftkey commented Jun 27, 2019

The hint to install x64 Node on Appveyor was removed accidentally in #190, which meant the prebuild scripts would only build for x86 Node and impacted users who didn't have their environment setup correctly.

Closes #196
Closes #195

@shiftkey shiftkey changed the title drop prebuild back to known good version restore appveyor setup to use x64 version of Node Jun 27, 2019
@shiftkey shiftkey merged commit 5e51391 into master Jun 27, 2019
@shiftkey shiftkey deleted the revert-prebuild-for-now branch June 27, 2019 10:12
childish-sambino pushed a commit to twilio/twilio-cli-core that referenced this pull request Jun 27, 2019
keytar issue resolved: atom/node-keytar#197
childish-sambino pushed a commit to twilio/twilio-cli-core that referenced this pull request Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

win32-x64 binaries missing from v4.10.0 release Does not works with Electron 5.0.5 ?
1 participant