Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Does not works with Electron 5.0.5 ? #195

Closed
1 task done
popod opened this issue Jun 25, 2019 · 4 comments · Fixed by #197
Closed
1 task done

Does not works with Electron 5.0.5 ? #195

popod opened this issue Jun 25, 2019 · 4 comments · Fixed by #197
Assignees

Comments

@popod
Copy link

popod commented Jun 25, 2019

Prerequisites

Description

Running and electron app on Windows 10 does this error:

\C:\Users\xxx\AppData\Local\Temp\4037a91f-06e5-4ddc-bff3-914e0958bcb9.tmp.node is not a valid Win32 application.
\\?\C:\Users\xxx\AppData\Local\Temp\4037a91f-06e5-4ddc-bff3-914e0958bcb9.tmp.node
    at process.func [as dlopen] (electron/js2c/asar.js:155)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:850)
    at Object.func [as .node] (electron/js2c/asar.js:164)
    at Module.load (internal/modules/cjs/loader.js:677)
    at tryModuleLoad (internal/modules/cjs/loader.js:609)
    at Function.Module._load (internal/modules/cjs/loader.js:601)
    at Module.require (internal/modules/cjs/loader.js:715)
    at require (internal/modules/cjs/helpers.js:14)
    at Object.<anonymous> (C:\Users\xxx\AppData\Local\Programs\xxx\resources\app.asar\node_modules\keytar\lib\keytar.js:1)
    at Object.<anonymous> (C:\Users\xxx\AppData\Local\Programs\xxx\resources\app.asar\node_modules\keytar\lib\keytar.js:61)

Electron-builder: 20.44.4
Electron: 5.0.5
Node-keytar: 4.10.0
Node: 12.4.0

@Eiarzate1
Copy link

Having same exact issue on Windows 10.

My dependencies:

"electron": "^5.0.5",
"electron-builder": "^20.44.4",
"electron-rebuild": "^1.8.5",
"keytar": "^4.10.0"

@popod
Copy link
Author

popod commented Jun 27, 2019

It seems that #196 describe the error reason.

@shiftkey do you have some time for checking this ? Thanks

@shiftkey
Copy link
Contributor

shiftkey commented Jun 27, 2019

@shiftkey do you have some time for checking this ? Thanks

I've not had time, but I can see this Appveyor build for the release only uploaded the x86 prebuilds to the GitHub release:

prebuild info build Uploaded 13 new prebuild(s) to Github
prebuild info build -> prebuilds/keytar-v4.10.0-electron-v53-win32-ia32.tar.gz
prebuild info build -> prebuilds/keytar-v4.10.0-electron-v54-win32-ia32.tar.gz
prebuild info build -> prebuilds/keytar-v4.10.0-electron-v57-win32-ia32.tar.gz
prebuild info build -> prebuilds/keytar-v4.10.0-electron-v64-win32-ia32.tar.gz
prebuild info build -> prebuilds/keytar-v4.10.0-electron-v69-win32-ia32.tar.gz
prebuild info build -> prebuilds/keytar-v4.10.0-electron-v70-win32-ia32.tar.gz
prebuild info build -> prebuilds/keytar-v4.10.0-node-v48-win32-ia32.tar.gz
prebuild info build -> prebuilds/keytar-v4.10.0-node-v51-win32-ia32.tar.gz
prebuild info build -> prebuilds/keytar-v4.10.0-node-v57-win32-ia32.tar.gz
prebuild info build -> prebuilds/keytar-v4.10.0-node-v59-win32-ia32.tar.gz
prebuild info build -> prebuilds/keytar-v4.10.0-node-v64-win32-ia32.tar.gz
prebuild info build -> prebuilds/keytar-v4.10.0-node-v67-win32-ia32.tar.gz
prebuild info build -> prebuilds/keytar-v4.10.0-node-v72-win32-ia32.tar.gz

This was upgraded in #187 so that's definitely a clue here.

@shiftkey
Copy link
Contributor

@popod thanks for that clue about the prebuilds. This should be fixed with v4.11.0 that is being published right now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants