Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Update @babel/preset-env #2552

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Nov 6, 2020

Description of the Change

This updates @babel/preset-env, which updates one of its deep dependencies: @babel/helper-compilation-targets.

Benefits

Allow building Atom with Node 12.16 or above

Applicable Issues

This fixes atom/atom#21091.
Based on atom-community/atom#111 (comment)
The original issue: nodejs/node#32107

Release Notes

  • bump @babel/preset-env
  • allow building Atom with Node 12.16 or above

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #2552 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2552   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files         236      236           
  Lines       13204    13204           
  Branches     1899     1899           
=======================================
  Hits        12337    12337           
  Misses        867      867           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5ff0bf...7610806. Read the comment docs.

@smashwilson
Copy link
Contributor

@smashwilson smashwilson merged commit b3f14e5 into atom:master Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build with nodejs > 12.16 due to ERR_PACKAGE_PATH_NOT_EXPORTED
2 participants