[WIP] Migrate to N-API #105
Conversation
|
Hey @dennisameling! 👋 Let me know if you need help with this, I might have time in the next days if needed 😄 I just did the same change in registry-js to practice and learn, so I might be helpful after all 🤣 |
|
@sergiou87 would be great if you could have a look at this! Have just invited you to my fork so you can directly work on this branch! Otherwise I might have some time during the weekend to look into this 👍🏼 |
|
Awesome, thanks! I'll take a look tomorrow 😄 |
| void ClearAuthorizationCache(const Nan::FunctionCallbackInfo<Value>& info) { | ||
| ClearAuthorizationCache(); | ||
| Napi::Value ClearAuthorizationCache(const Napi::CallbackInfo& info) { | ||
| ClearAuthorizationCacheImpl(); |
There was a problem hiding this comment.
I needed to rename this, otherwise the compiler would complain at https://github.com/atom/fs-admin/pull/105/files#diff-7b9337fcff3141736997afd31f7a2764b3538153922282c8407af5f43d543cabR90
|
@dennisameling this should be good to go now! Take a look at the changes, please. I think they all make sense 😄 /cc @billygriffin |
Inspired from atom/node-keytar#268, using https://github.com/nodejs/node-addon-api/blob/main/doc/conversion-tool.md
This is a very rough first commit that needs quite some work still!