This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix (from template, click to expand):
Identify the Bug
#22687 (comment)
The existence of Electron 11.5.0 (the final release of the Electron 11.x series) was pointed out by @mfonville in the main Electron 11 upgrade PR. (See comment linked above). The bug is... We're out of date!
Description of the Change
Update Atom to use Electron 11.5.0 instead of 11.4.12. The only changes in this Electron release are a few security patches cherry-picked from newer Chromium and V8. See the release notes:
Alternate Designs
No alternatives were seriously considered. (I like security patches, and I lack the ability to whip up, say, an Electron 12 upgrade right now...)
Possible Drawbacks
Probably none. These are really small security patches, hopefully they aren't buggy patches... 👀
Verification Process
Tests pass in CI at my fork: https://dev.azure.com/DeeDeeG/b/_build/results?buildId=1233
(Please disregard the failed "UploadArtifacts" job, that's CI-specific and I don't think anyone has gotten that to pass on forks of the Atom repo yet -- that failing only means I'm not running CI on the official atom/atom repo.)
Release Notes
⬆️ Electron 11.5.0