Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

⬆️ Electron 11.5.0 #23692

Merged
merged 1 commit into from
Apr 12, 2022
Merged

⬆️ Electron 11.5.0 #23692

merged 1 commit into from
Apr 12, 2022

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Mar 10, 2022

Requirements for Contributing a Bug Fix (from template, click to expand):

Identify the Bug

#22687 (comment)

The existence of Electron 11.5.0 (the final release of the Electron 11.x series) was pointed out by @mfonville in the main Electron 11 upgrade PR. (See comment linked above). The bug is... We're out of date!

Description of the Change

Update Atom to use Electron 11.5.0 instead of 11.4.12. The only changes in this Electron release are a few security patches cherry-picked from newer Chromium and V8. See the release notes:

Alternate Designs

No alternatives were seriously considered. (I like security patches, and I lack the ability to whip up, say, an Electron 12 upgrade right now...)

Possible Drawbacks

Probably none. These are really small security patches, hopefully they aren't buggy patches... 👀

Verification Process

Tests pass in CI at my fork: https://dev.azure.com/DeeDeeG/b/_build/results?buildId=1233

(Please disregard the failed "UploadArtifacts" job, that's CI-specific and I don't think anyone has gotten that to pass on forks of the Atom repo yet -- that failing only means I'm not running CI on the official atom/atom repo.)

Release Notes

⬆️ Electron 11.5.0

@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Apr 9, 2022

Test failure is unrelated. It passed CI on my CI account, given enough chances to rerun. Failure appears to be, as usual, unrelated test failures that (unfortunately) happen sort of randomly on every branch.

I think it would be sensible to include this in 1.61-releases branch, because otherwise there will be 11.4.12 in the final Atom1.61... And Electron 11.5.0 just adds a few small security fixes cherry-picked from upstream Chromium and V8.

Consider merging, in order to get a few more security patches into Atom. Thanks.

@sadick254 sadick254 merged commit 6cdc47c into atom:master Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants