Bump Electron Version

[mansona]

hey folks 👋 this PR is just to start a discussion as a result of the fact that we're lagging behind with Electron versions and it's causing some issues now for day-to-day development. For example the linter-eslint plugin (a very popular plugin) is not able to upgrade since a lot of eslint plugins are moving to ESM (along with the rest of the JavaScript community right now) AtomLinter/linter-eslint#1442

I know that this PR isn't good enough to get merged as it is but a) I wanted to see what the results were in the CI and b) I wanted some help identifying the required steps to get this over the line. I'm happy to help but I'm looking for some guidance 👍

[icecream17]

According to the windows errors it seems like it comes from an old nested dependency inside tree-sitter.

And updating seems to fix the problem:

atom/package.json

Line 164 in d016186

"tree-sitter": "git+https://github.com/DeeDeeG/node-tree-sitter.git#bb298eaae66e0c4f11908cb6209f3e141884e88e",

should be:

 "tree-sitter": "git+https://github.com/DeeDeeG/node-tree-sitter.git#964c7977b215f193226eddd3a5ca3ef945033696", 

This updates tree-sitter > prebuild-install to version 6

And there's some c++ node-gyp warnings for both @atom/fuzzy-native@1.2.1 and pathwatcher@8.1.2 (both latest)

[sadick254]

Hey, @mansona you have to make sure all the native modules work with the new electron version. Check that they are able to compile.
Sometimes a simple update to electron breaks a lot of things. Take a look at #22687 for reference.

[icecream17]

There's a comment saying to update this to true:

atom/src/main-process/start.js

Lines 43 to 44 in 10f7d45

	// TodoElectronIssue this should be set to true before Electron 12 - https://github.com/electron/electron/issues/18397
	app.allowRendererProcessReuse = false;

(but note)
Since the option doesn't exist in electron 14, the lines can be deleted
electron/electron#18397

Edit: Linking to #23313, related?

[icecream17]

This fixes

#21825 (electron 13.1.0)
#23036 (https://bugzilla.suse.com/show_bug.cgi?id=1191012 electron/electron#31091 electron 13)

Possible duplicates
#23167
#23608

Possible issues

atom/keyboard-layout#62

Related prs

• Ran npm update to fix nan warnings node-oniguruma#114
• Blocked by Update nan keyboard-layout#63 (I tested it locally and it fixes the keyboard-layout bootstrap error)
• shell.moveItemToTrash was removed (electron 13)
  So the two uses here need to be updated
  https://github.com/atom/tree-view/blob/bc42868def5e13521cedeb8337e40917631969f4/lib/tree-view.coffee#L649
  https://github.com/atom/tree-view/blob/0e16dd2c5ab76583550525eb89349dcede03aad3/spec/tree-view-package-spec.coffee#L2809

[brettz9]

FWIW, if upgrading to the latest doesn't work (or work easily), bumping up to v13 should be enough as far as linter-eslint since Node v14.7 is supposedly where ESM stabilized.

[AlexWayfer]

Now Atom fails to launch after minor updated of glibc on Arch Linux: https://bugs.archlinux.org/task/75902

Please, update dependencies to the actual versions, especially framework like Electron.

[DAC324]

Now Atom fails to launch after minor updated of glibc on Arch Linux: https://bugs.archlinux.org/task/75902
In that issue report, there a proposal as follows (second comment):

They need to update electron or apply this patch: https://github.com/electron/electron/commit/993ecb5bdd5c57024c8718ca6203a8f924d6d574

Unfortunately, the files to be patched, do not seem to be included in atom's sources so it looks like that patch ist not usable for atom.