-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Windows with MSVC 2019 #44
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs rebasing
eb75182
to
0c956dd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We need to update npm in a separate pull request. |
f3c93bd
to
e1645f5
Compare
b1b536b
to
9461eb2
Compare
Python version is causing issues in the installation of windows-build-tools. |
What was the error with Python 3? I am trying to debug what happened so I know what to do if this comes up again. But I am not sure what happened. Edit: Endless install log, right? Not sure what causes that. I saw it outside of CI once. I don't think it's to do with Python versions. |
We can drop the Committing here, but you have my permission to just delete the commit if you don't want it. By the way: We should be able to drop the If we update the macOS image to 10.15 macOS Catalina, we can drop npm updates altogether on every OS. |
6af59f1
to
ace1d46
Compare
I want to test |
b1e1bff
to
fc5d357
Compare
We can use the Visual Studio install included with the CI image. Saves about two minutes of preparation time.
For the record: |
Description of the change
This uses MSVC 2019 to build Atom on Windows. It does this on the windows-2019 image in Azure. To test the backward compatibility, the built Atom is tested on windows-2016.
Verification
The tests pass. Extra tests are added to test the backward compatibility on older Windows.
Drawbacks
none
Release notes