New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Validator, create ValidatorRule class #20

Merged

DarkSide666 merged 49 commits into develop from feature/validator-rule

Apr 19, 2024

Member

DarkSide666 commented Apr 14, 2024 •

edited

introduce ValidatorRule class
refactor Validator class
set proper phpstan-types
slightly improve tests
proper value comparing, better support for complex field types

DarkSide666 added 3 commits

April 14, 2024 14:59


          introduce ValidatorRule and refactor code and add/fix tests

579a61a


          add phptype ValidatorCallback

ac38294


          set phpstan-type for valitron rules

142e503

DarkSide666 mentioned this pull request

Implement ValidatorRule and refactor Validator #12

Closed

DarkSide666 self-assigned this

mvorisek reviewed

View reviewed changes

src/Validator.php Outdated Show resolved Hide resolved

mvorisek reviewed

View reviewed changes

src/ValidatorRule.php Outdated Show resolved Hide resolved

mvorisek reviewed

View reviewed changes

tests/BasicTest.php Show resolved Hide resolved

mvorisek reviewed

View reviewed changes

tests/BasicTest.php Outdated Show resolved Hide resolved

mvorisek reviewed

View reviewed changes

tests/BasicTest.php Show resolved Hide resolved

mvorisek reviewed

View reviewed changes

tests/BasicTest.php Outdated Show resolved Hide resolved


          address review comments

94fd394

mvorisek reviewed

View reviewed changes

src/Validator.php Outdated Show resolved Hide resolved


          improve doc

627f26c

mvorisek reviewed

View reviewed changes

src/Validator.php Outdated Show resolved Hide resolved

mvorisek reviewed

View reviewed changes

src/Validator.php Outdated Show resolved Hide resolved

mvorisek reviewed

View reviewed changes

src/Validator.php Outdated Show resolved Hide resolved

mvorisek reviewed

View reviewed changes

src/Validator.php Outdated Show resolved Hide resolved

mvorisek reviewed

View reviewed changes

src/Validator.php Outdated Show resolved Hide resolved

DarkSide666 added 11 commits

April 14, 2024 18:57


          sort validators, rename method to addRule

48ae9aa


          add ValidatorCondition typehint and fix it

96a3ead


          better user Model compare method

e57308b


          add tests for complex data type (date)

5135e37


          test

09cea81


          change test to show how it fails for empty DateTime

582c6b9


          show the problem


          extend Valitron class and fix bugs there

2126a95


          proper validation

4846bfc


          cs fix

b84cc8d


          add Override attribute

7db8c32

DarkSide666 and others added 19 commits

April 18, 2024 13:42


          Update src/ValitronValidator.php

8585e19

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>


          Update src/ValitronValidator.php

ce6c3fa

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>


          address review

fc779f5


          start adding tests for fixed valitron validator

fbb007f


          tests

33dd6ad


          test

ee3ef0a


          simplify tests

d4eadd7


          cs fixes

f592bb3


          test

64b609c


          test

2ff9e0e


          test

65318ba


          catch warnings

624f63d


          test

ed288c6


          test

d559369


          test

ddc468e


          remove comments

d51a941


          * reorder tests to put expected exceptions last

2573e64

* improve tests coverage


          we do not create coverage report with PHP 7.4

cfd2a66


          cs fix

2fbcf7a

mvorisek reviewed

View reviewed changes

tests/ValitronValidatorTest.php Outdated Show resolved Hide resolved

mvorisek reviewed

View reviewed changes

tests/ValitronValidatorTest.php Outdated Show resolved Hide resolved

mvorisek reviewed

View reviewed changes

tests/ValitronValidatorTest.php Outdated Show resolved Hide resolved

mvorisek reviewed

View reviewed changes

tests/ValitronValidatorTest.php Outdated Show resolved Hide resolved

DarkSide666 added 3 commits

April 19, 2024 23:05


          test

85e88c2


          cs fixes

7733fa2


          check for precise message

9e06c8c

mvorisek reviewed

View reviewed changes

tests/ValitronValidatorTest.php Outdated Show resolved Hide resolved


          variable naming

35d4082

DarkSide666 merged commit 9b02761 into develop

29 checks passed

DarkSide666 deleted the feature/validator-rule branch

April 19, 2024 22:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment