Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add App::terminate() stream support #2028
Add App::terminate() stream support #2028
Changes from 4 commits
bb9bcd2
04ea56e
185e648
269ff3e
d412508
b8fed00
e66f622
0fb6c5a
895129a
fd8dfc6
e724129
2177373
b3b250a
c827251
1881778
b015683
6f85bfd
b94b136
568d718
84dc52e
6801f94
e3b4baa
e354ea9
65fbd8b
e351478
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test should test sending large (10GB+) data with known pattern to test the response is not materialized somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I have no idea how to write that. Will have to ask ChatGPT :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implemented and tested with 6GB
the main bottleneck seems to be in Guzzle HTTP client - guzzle/guzzle#3115
until improved, let's test the streaming support with 50 MB only