Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable deprecated maligned linter #303

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Re-enable deprecated maligned linter #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 18 additions & 6 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,28 @@ linters:
- golint
- gosec
- govet

# Deprecated linter, but still functional as of golangci-lint v1.39.0.
# See https://github.com/atc0005/go-ci/issues/302 for more information.
- maligned

- misspell
- prealloc
- staticcheck
- stylecheck
- unconvert
#
# Disable fieldalignment settings until the Go team offers more control over
# the types of checks provided by the fieldalignment linter or golangci-lint
# does so.
#
# See https://github.com/atc0005/go-ci/issues/302 for more information.
#

disable:
- maligned
# disable:
# - maligned

linters-settings:
govet:
enable:
- fieldalignment
# linters-settings:
# govet:
# enable:
# - fieldalignment
30 changes: 24 additions & 6 deletions unstable/.golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,26 @@ linters:
- golint
- gosec
- govet

# Deprecated linter, but still functional as of golangci-lint v1.39.0.
# See https://github.com/atc0005/go-ci/issues/302 for more information.
- maligned

- misspell
- prealloc
- staticcheck
- stylecheck
- unconvert

disable:
- maligned
#
# Disable govet:fieldalignment, re-enable deprecated maligned linter until the
# Go team offers more control over the types of checks provided by the
# fieldalignment linter or golangci-lint does so.
#
# See https://github.com/atc0005/go-ci/issues/302 for more information.
#
# disable:
# - maligned

linters-settings:
gocognit:
Expand All @@ -57,7 +69,13 @@ linters-settings:
gocyclo:
# minimal code complexity to report, 30 by default (but we recommend 10-20)
min-complexity: 15

govet:
enable:
- fieldalignment
#
# Disable govet:fieldalignment, re-enable deprecated maligned linter until the
# Go team offers more control over the types of checks provided by the
# fieldalignment linter or golangci-lint does so.
#
# See https://github.com/atc0005/go-ci/issues/302 for more information.
#
# govet:
# enable:
# - fieldalignment