Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated linters: maligned, scopelint #153

Closed
atc0005 opened this issue Apr 5, 2021 · 0 comments · Fixed by #155
Closed

Replace deprecated linters: maligned, scopelint #153

atc0005 opened this issue Apr 5, 2021 · 0 comments · Fixed by #155
Assignees
@atc0005
Labels
bug Something isn't working linting
Milestone
v0.5.1

Comments

@atc0005
Copy link
Owner

atc0005 commented Apr 5, 2021

Linters:

dnsc/.golangci.yml

Line 27 in 85d7da9

- maligned

dnsc/.golangci.yml

Line 33 in 85d7da9

- scopelint

See these issues for more info:
@atc0005 atc0005 added bug Something isn't working config linting labels Apr 5, 2021
@atc0005 atc0005 added this to the v0.5.1 milestone Apr 5, 2021
@atc0005 atc0005 self-assigned this Apr 5, 2021
@atc0005 atc0005 removed the config label Apr 5, 2021
This was referenced Apr 5, 2021
Closed
Merged
atc0005 added a commit that referenced this issue Apr 5, 2021
@atc0005
Replace deprecated linters
4e8c6bf 
- replace deprecated `maligned` linter with
  `govet: fieldalignment`
- replace deprecated `scopelint` linter with
  `exportloopref`

refs GH-153
@atc0005 atc0005 mentioned this issue Apr 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working linting
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging a pull request may close this issue.

Replace deprecated linters atc0005/dnsc
1 participant
@atc0005