Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fieldalignment: struct with X pointer bytes could be Y (govet) #152

Closed
atc0005 opened this issue Apr 5, 2021 · 1 comment · Fixed by #154
Closed

fieldalignment: struct with X pointer bytes could be Y (govet) #152

atc0005 opened this issue Apr 5, 2021 · 1 comment · Fixed by #154
Assignees
@atc0005
Labels
bug Something isn't working linting
Milestone
v0.5.1

Comments

@atc0005
Copy link
Owner

atc0005 commented Apr 5, 2021 •
edited

Multiple linting issues exposed by the changes in atc0005/go-ci#287 and atc0005/go-ci#288:

config/config.go:192:13: fieldalignment: struct with 312 pointer bytes could be 304 (govet)
type Config struct {
            ^
config/config.go:209:21: fieldalignment: struct with 136 pointer bytes could be 120 (govet)
type configTemplate struct {
                    ^
dqrs/queryresponse.go:23:23: fieldalignment: struct with 80 pointer bytes could be 56 (govet)
type DNSQueryResponse struct {
                      ^
@atc0005 atc0005 added bug Something isn't working linting labels Apr 5, 2021
@atc0005 atc0005 added this to the v0.5.1 milestone Apr 5, 2021
@atc0005 atc0005 self-assigned this Apr 5, 2021
@atc0005
Copy link
Owner Author

atc0005 commented Apr 5, 2021

refs #153

atc0005 added a commit that referenced this issue Apr 5, 2021
@atc0005
Fix govet:fieldalignment linting errors
28bb2a4 
Change field order of affected structs in order to reduce
allocation requirements and pass `fieldalignment` linting check.

refs GH-152
@atc0005 atc0005 mentioned this issue Apr 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working linting
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging a pull request may close this issue.

Fix govet:fieldalignment linting errors atc0005/dnsc
1 participant
@atc0005