refactor: add tests for old api #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
requested review from
fmvilas,
jonaslagoni,
derberg and
asyncapi-bot-eve
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
smoya
reviewed
Sep 22, 2022
| @@ -39,7 +39,7 @@ export enum SchemaTypesToIterate { | |||
|
|
|||
| export type TraverseOptions = { | |||
| callback: TraverseCallback | |||
| schemaTypesToIterate: SchemaTypesToIterate[] | |||
| schemaTypesToIterate: Array<`${SchemaTypesToIterate}`>; | |||
There was a problem hiding this comment.
I'm lost on this 😆 Is this the preferable way? Or it was a bug?
There was a problem hiding this comment.
It's an interpolation of enum values as union. Feature in the TS 4.1, so you can put schemaTypesToIterate as array of normal string (but with values from enum) or SchemaTypesToIterate signature for given enum value.
|
/rtm |
magicmatatjahu
added a commit
to magicmatatjahu/parser-js
that referenced
this pull request
Oct 3, 2022
derberg
pushed a commit
that referenced
this pull request
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cc @smoya
Related issue(s)
Part of #481
Part of #482