refactor: update API according to latest changes #54
Conversation
Thanks! 馃帀 I decided to move into this task because of that reason in particular. Anyway, this API can contain errors so we should be able to detect them as soon as possible, that's why we are prioritizing implementation time over design time. |
|
@magicmatatjahu @jonaslagoni anything you see potentially wrong? |
| - servers() : `Server[]` | ||
| - summary() : `string` | `undefined` | ||
| - tags() : `Tag[]` | ||
| - tags() : `Tags` |
There was a problem hiding this comment.
Make sure you are consistent either use a wrapper object or a simple array, don't use both IMO. I.e. we use channel[]
docs/v1.md
Outdated
| ## Message | ||
| - binding(bindingProtocol) : `any` | `undefined` | ||
| - bindingProtocol : `enum{'amqp', 'amqps', 'http', 'https', 'jms', 'kafka', 'kafka-secure', 'mqtt', 'secure-mqtt', 'stomp', 'stomps', 'ws', 'wss'}` | ||
| - bindings() : `Bindings` | ||
| - channels() : `Channel[]` |
docs/v1.md
Outdated
| - hasTitle() : `boolean` | ||
| - headers() : `Schema` | `undefined` | ||
| - id() : `string` | ||
| - name() : `string` | `undefined` | ||
| - operations() : `Operation[]` |
|
Should I.e. What do you think @magicmatatjahu @jonaslagoni @Souvikns ? |
|
I would not focus on creating the intents for JSON Schema, and keep it |
We can always change it before releasing the final API anyway so 馃憤 for it |
|
/rtm |
|
I see I didn't comment in time 馃槃 But I agree with Jonas, Schema Object should work in a recursive way. |
|
馃帀 This PR is included in version 1.0.0 馃帀 The release is available on GitHub release Your semantic-release bot 馃摝馃殌 |
Description
Part of #53
This PR updates the current API with the latest changes applied in https://github.com/asyncapi/parser-js/tree/next-major and in asyncapi/parser-js#496.
I hope did not miss any other change 馃槄 .
cc @magicmatatjahu @Souvikns
Related issue(s)
#53