size_hint setup for streams #967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recommend seeing how the same method is implemented in |
…e_hint method of the futures-rs crate
|
Okay I've taken a look an implemented those I thought would make sense. |
|
There is a problem related to the test pipeline powerpc-unknown-linux-gnu, this pipeline needs SO_INCOMING_CPU constant from the libc to complete the build. But with libc 0.2.91 it doesn't have this constant, should we open a issue to address this issue? So that it won't hinder other PR's. |
mich2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR regarding the issue 953. This PR needs a review because it is possible that I have made a lot of errors, because it is not always easy to write size_hint code.