Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stream): add send guards on collect #665

Merged
merged 4 commits into from Jun 27, 2020
Merged

Conversation

yoshuawuyts
Copy link
Contributor

WIP towards fixing #639. This currently doesn't work yet; needs further investigation. Thanks!

@dignifiedquire
Copy link
Member

@stjepang any chance you could help with this. This is blocking me from using Streams inside task::spawn at the moment. I have tried, but failed to understand the extension_trait macro, which I believe needs to be modified in order to add the Send bound on fn collect

@dignifiedquire dignifiedquire changed the title attempt to fix Send guards on collect Fix Send guards on collect Jun 27, 2020
@dignifiedquire dignifiedquire marked this pull request as ready for review June 27, 2020 14:14
Copy link
Contributor Author

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dignifiedquire dignifiedquire changed the title Fix Send guards on collect fix(stream): add send guards on collect Jun 27, 2020
@dignifiedquire dignifiedquire merged commit c82b1ef into master Jun 27, 2020
@dignifiedquire dignifiedquire deleted the collect-fix-send branch June 27, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants