DoubleEndedStream extension #562
Merged
+472
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
reviewed
Nov 20, 2019
yoshuawuyts
reviewed
Nov 20, 2019
yoshuawuyts
reviewed
Nov 20, 2019
k-nasa
reviewed
Nov 20, 2019
yjhmelody
reviewed
Nov 22, 2019
|
I'm kind of stuck with figuring out how and where to reexport different chunks of the API. Could someone nudge me in the right direction? |
|
@felipesere could you maybe share more details where you're getting stuck? What are you trying to do that isn't working? This is a rather large PR, and I don't have the information quite ready the way you do I think 😅 |
|
Oops, I accidentally pushed changes onto this branch, then reset the changes with a force push. It should be all good now. If anyone's wondering what had happened; sorry about that!. |
yoshuawuyts
reviewed
Dec 12, 2019
Still outstanding: How do I hide the concrete structs from the trait?
yoshuawuyts
approved these changes
Dec 13, 2019
This was referenced Dec 13, 2019
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first stab at a skeleton implementation of the
DoubleEndedStreamextension.Docs are mostly still outstanding, I'll add them in based on their Stream variation as this evolves.
I also added a dummy "Sample" implementation of
DoubleEndedStreamfor a vec.While not the worst, this probably needs a better name and place,
possibly even
double_ended_stream::from_iter(...)?Looking forward for any feedback and advice :)
#129