Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stream unzip #543

Merged
merged 5 commits into from
Nov 25, 2019
Merged

Add stream unzip #543

merged 5 commits into from
Nov 25, 2019

Conversation

k-nasa
Copy link
Member

@k-nasa k-nasa commented Nov 15, 2019 •
edited

ref: #129

yjhmelody
yjhmelody reviewed Nov 15, 2019
View reviewed changes
src/stream/stream/unzip.rs Outdated Show resolved Hide resolved
src/stream/stream/unzip.rs Outdated Show resolved Hide resolved
src/stream/stream/unzip.rs Outdated Show resolved Hide resolved
src/stream/stream/unzip.rs Outdated Show resolved Hide resolved
taiki-e
taiki-e reviewed Nov 15, 2019
View reviewed changes
src/stream/stream/unzip.rs Outdated Show resolved Hide resolved
taiki-e
taiki-e reviewed Nov 15, 2019
View reviewed changes
src/stream/stream/unzip.rs Outdated Show resolved Hide resolved
@k-nasa k-nasa marked this pull request as ready for review November 15, 2019 17:05
@k-nasa
Copy link
Member Author

k-nasa commented Nov 16, 2019

Oops! Unzip implementation PR has been submitted in the past. #232

@tirr-c This PR seems to have stopped, what should I do?

@tirr-c
Copy link
Contributor

tirr-c commented Nov 16, 2019

@k-nasa I'll close mine -- returning two streams was pretty experimental, and now I think collecting with Extend is a better idea.

@tirr-c tirr-c mentioned this pull request Nov 16, 2019
Closed
@k-nasa
Copy link
Member Author

k-nasa commented Nov 17, 2019

I like idea return two sterams. I was thinking same it.
"But is there a need to consume a stream and get a new stream?"
I thought, and made it as it is now.

taiki-e
taiki-e reviewed Nov 20, 2019
View reviewed changes
src/stream/stream/mod.rs Outdated Show resolved Hide resolved
taiki-e
taiki-e approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-nasa @taiki-e
Update src/stream/stream/mod.rs
d146d95 
Co-Authored-By: Taiki Endo <te316e89@gmail.com>
@k-nasa k-nasa requested a review from a user November 24, 2019 13:28
yoshuawuyts
yoshuawuyts approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks heaps!

@yoshuawuyts yoshuawuyts merged commit 850b8ae into async-rs:master Nov 25, 2019
@Earthson Earthson mentioned this pull request Feb 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjhmelody yjhmelody yjhmelody left review comments

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k-nasa @tirr-c @yoshuawuyts @yjhmelody @taiki-e