Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stream by_ref #538

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Add stream by_ref #538

merged 2 commits into from
Nov 15, 2019

Conversation

k-nasa
Copy link
Member

@k-nasa k-nasa commented Nov 15, 2019

ref: #129

@yoshuawuyts yoshuawuyts mentioned this pull request Nov 15, 2019
Open
87 tasks
yoshuawuyts
yoshuawuyts reviewed Nov 15, 2019
View reviewed changes
src/stream/stream/mod.rs
#
# }) }
```
"#]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we maybe mark this as "unstable"?

I'm quite sure this is fine, but just to be sure all new APIs introduced are marked unstable first, so we can stabilize them later. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I forget it always...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-nasa no worries! Thanks for fixing!

@yoshuawuyts yoshuawuyts merged commit 693a725 into async-rs:master Nov 15, 2019
@k-nasa k-nasa deleted the stream_by_ref branch November 15, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k-nasa @yoshuawuyts