Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stream::count #368

Merged
merged 8 commits into from
Nov 14, 2019
Merged

add stream::count #368

merged 8 commits into from
Nov 14, 2019
+73 −0

Conversation

starsheriff
Copy link
Contributor

ref #129

@starsheriff starsheriff marked this pull request as ready for review October 18, 2019 06:04
ghost
ghost previously requested changes Oct 20, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit

src/stream/stream/count.rs Outdated Show resolved Hide resolved
@starsheriff starsheriff requested a review from a user October 20, 2019 21:41
k-nasa
k-nasa approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@k-nasa k-nasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. @stjepang how is it?

src/stream/stream/mod.rs Outdated Show resolved Hide resolved
@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Oct 28, 2019
@yoshuawuyts
Copy link
Contributor

Filed #401 to fix CI. Let's re-run it after we merge that. Thanks!

ghost
ghost reviewed Nov 1, 2019
View reviewed changes
src/stream/stream/count.rs Outdated
Comment on lines 15 to 16
pin_utils::unsafe_pinned!(stream: S);
pin_utils::unsafe_unpinned!(count: usize);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rebase this branch and use pin_project! here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, can do that. Sorry for the late reply, I was quite busy the last weeks.

@starsheriff
Copy link
Contributor Author

so, changed to using pin_project. Guess it is ready now.

@starsheriff starsheriff requested a review from a user November 11, 2019 21:27
@starsheriff
Copy link
Contributor Author

@stjepang, can you have a look?

k-nasa
k-nasa approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@k-nasa k-nasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks!!

k-nasa
k-nasa reviewed Nov 14, 2019
View reviewed changes
src/stream/stream/mod.rs Outdated Show resolved Hide resolved
@k-nasa k-nasa self-requested a review November 14, 2019 09:06
@k-nasa k-nasa mentioned this pull request Nov 14, 2019
Closed
@starsheriff @k-nasa
Update src/stream/stream/mod.rs
9ebe41f 
Co-Authored-By: nasa <htilcs1115@gmail.com>
@yoshuawuyts yoshuawuyts dismissed ghost ’s stale review November 14, 2019 21:40

nits implemented

@yoshuawuyts yoshuawuyts merged commit c58747b into async-rs:master Nov 14, 2019
@yoshuawuyts yoshuawuyts mentioned this pull request Nov 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

@k-nasa k-nasa Awaiting requested review from k-nasa

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@starsheriff @yoshuawuyts @k-nasa