Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add crate::stream::Stream bound #214

Closed

Conversation

yoshuawuyts
Copy link
Contributor

This is an attempt to fix the problems in #213. Put out as a separate branch because we're doing some rather gnarly things here and we may want to try a few approaches. Thanks!

Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
…eaks compilation

Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts
Copy link
Contributor Author

Looks like f5451c2 breaks our bounds again, because a generic futures_rs::stream::Stream -> async_std::stream::Stream bound makes this impossible again.

Good of the trait system, but this isn't great for us.

@yoshuawuyts yoshuawuyts deleted the stream-bound branch September 19, 2019 11:25
@yoshuawuyts yoshuawuyts mentioned this pull request Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant