Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Future description #117

Closed
wants to merge 1 commit into from

Conversation

JohnTitor
Copy link
Contributor

Fixes #103

@ghost
Copy link

ghost commented Aug 27, 2019

I kind of feel it would be best to just delete that sentence :) wdyt, @skade?

@skade
Copy link
Collaborator

skade commented Aug 27, 2019

@stjepang I'm not attached to the sentence as is, but we need to inform people of some way what the different kind of futures are and how the libraries relate.

@JohnTitor
Copy link
Contributor Author

Hmm, what I should do? Should improve the sentence or remove it?

@ghost
Copy link

ghost commented Aug 28, 2019

Hmm, perhaps we should do another pass over the whole section? It seems to imply a few things that are potentially confusing or misleading:

  1. It says Future is a type, but it really is a trait.
  2. It talks about differences between futures::future::Future and std::future::Future, but they are the same trait.

@ghost ghost requested a review from skade August 28, 2019 20:06
@yoshuawuyts
Copy link
Contributor

ping @skade

@yoshuawuyts yoshuawuyts added the documentation Improvements or additions to documentation label Sep 18, 2019
@joodicator
Copy link

While reading https://book.async.rs/overview/std-and-library-futures.html, which at time of writing currently still incorrectly states that std::future::Future and futures::future::Future are distinct, I was confused, and it took me about half an hour to establish what was actually going on. It would be good to have this changed, since, as I can attest, the misinformation is having real-world consequences. Aside from that, I appreciate the information about asynchronous Rust.

@joshtriplett
Copy link
Contributor

#1024

@joshtriplett
Copy link
Contributor

Fixed by #1024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Book chapter 1.2 futures::future::Future description
5 participants