Add a prefer_single_line_descriptions option on SDLExportOptions #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default export uses three lines for each description. Single-line descriptions improve the readability of the exported SDL when there are many short descriptions.
I confirmed that graphql-code-generator properly handles SDL with this escaping.
|
Thanks! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default export uses three lines for each description. Single-line descriptions can improve the readability of the exported SDL when there are many short descriptions.
With
prefer_single_line_descriptions, the exported output looks likehttps://gist.github.com/ivan/f8e394651a86a016a7d99258fbc556ff
instead of
https://gist.github.com/ivan/9b0e473e4a2a600d93f1b1610a40260a
Please let me know what you think, I am happy to change things if you want.