add nodes exposure on ConectionType so nesting through edges isn't always needed. #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, please use night Rust to format the code 🙂 |
…ways needed. When there are no extra edge fields, we can short-cut and just access nodes to get all the entries (since pageInfo still provides the endCursor) See Github's GraphQL API for an example of this usage. And this alluded to on the GraphQL pagination page ( https://graphql.org/learn/pagination/#end-of-list-counts-and-connections )
urkle
force-pushed
the
feat-connection-nodes
branch
from
42813ab
to
6dc7f4a
Compare
|
Thanks 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no extra edge fields, we can short-cut and just access nodes to get all the entries (since pageInfo still provides the endCursor)
See Github's GraphQL API for an example of this usage. And this alluded to on the GraphQL pagination page ( https://graphql.org/learn/pagination/#end-of-list-counts-and-connections )