run book tests and fix book examples #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- examples to fix still
- error_extensions.md ResultExt example does not compile!
- trait ErrorExtensions is not implemented for ParseIntError
- dataloader
- requires sqlx to work. So we either "stub" it OR we rewrite them simpler to use a simple "faux" db library
|
awesome, thank you so much for making this! 👏 |
…rust version - this has to exclude integrations/tide as an indirect dependency requires rust 1.59.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run mdbook tests so we ensure the examples actually compile
There are several examples that were broken and did not actually work (thus making it hard to learn to use async-graphql)