update darling version #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkle
force-pushed
the
feat-update-darling
branch
3 times, most recently
from
bca88d3
to
52f131d
Compare
- zxcvbn uses this newer version as well
urkle
force-pushed
the
feat-update-darling
branch
from
52f131d
to
4c8e9a3
Compare
|
@sunli829 I rebased this against current master and all tests are passing. |
|
Thank you so much! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zxcvbn uses this newer version as well
according to the changelog for darling we should be able to remove the
#[darling(default)]from any of the Option<> fields. Let me know if you want me to do that for this PR.