Update helpers v3.2.1 #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will obviously need the rebase before merging, e.g. the pytest5 issues has been addressed in #288 |
|
@bsipocz - Please trigger a new CI build here. |
|
@cdeil - shall I rebase, too? |
|
ok |
bsipocz
force-pushed
the
update-helpers-v3.2.1
branch
from
9dcf208
to
8e9ed7e
Compare
|
Ah, I see, this PR drops Python 2 support, that wasn't clear to me before. So this should not be merged for now. When to drop Python 2 support is being discussed in #241 |
|
Yes, thus is milestoned to 0.6, that is in my understanding the first version that will be python 3 only. |
|
I'm 👍 on merging this and ditching py2 support from 0.5 forward |
|
push the button then ;) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an exact copy of #287 that has been reset from master given that we need to keep python2 support just for a little longer.