Fix pytest.raises usage for pytest 5 #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #288, i.e. the pytest.raises related fails that appeared with the pytest 5 release.
I have changed from
err
orexc
toexpinfo
to make it clear(er) that it's an anExceptionInfo
object, not anException
object. This is following the variable name pytest uses in its docs: https://docs.pytest.org/en/latest/assert.html#assertions-about-expected-exceptions@bsipocz - I would suggest to revert #287 for now, and only then merge this in. Assigning to you.