Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest pytest version #8954

Merged
merged 3 commits into from Jul 7, 2019
Merged

Use latest pytest version #8954

merged 3 commits into from Jul 7, 2019

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jul 3, 2019

This PR removes the version limitations for pytest as now locally everything passes with v5.0.0

closes #8934

@bsipocz bsipocz added testing no-changelog-entry-needed 💤 merge-when-ci-passes Do not use: We have auto-merge option now. labels Jul 3, 2019
@bsipocz bsipocz added this to the v3.2.2 milestone Jul 3, 2019
Copy link
Contributor

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested w/ and w/o asdf installed; LGTM.

@bsipocz
Copy link
Member Author

bsipocz commented Jul 3, 2019

Yes, the asdf install issue seems to be a red herring, quite embarrassingly, today I couldn't reproduce it at all.

@bsipocz
Copy link
Member Author

bsipocz commented Jul 7, 2019

The mpldev failure is unrelated as has been fixed in master already. This is good to go.

@saimn saimn merged commit 84fb4ad into astropy:master Jul 7, 2019
@saimn
Copy link
Contributor

saimn commented Jul 7, 2019

Thanks Brigitta.

bsipocz pushed a commit that referenced this pull request Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: CircleCI 32-bit job is broken
3 participants