New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve str AssertionErrors on ExceptionInfo objects in pytest 5 #8949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would the changelog entry go under Bug fixes: |
@dhomeier - no, this is neither user facing nor has any real behaviour change, so don't need a changelog. |
bsipocz
approved these changes
Jul 2, 2019
bsipocz
added
the
💤 merge-when-ci-passes
Do not use: We have auto-merge option now.
label
Jul 2, 2019
Thanks @dhomeier! |
@bsipocz - no, definitely no user-relevant changes here, but it might be useful to document for casual developers and contributors - don't know where to best put it though. |
bsipocz
added a commit
that referenced
this pull request
Jul 7, 2019
Resolve str AssertionErrors on ExceptionInfo objects in pytest 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix errors of the kind
that started to appear with pytest 5.0.0 as discussed in #8934.
General remedy is to call
str(excinfo.value)
rather thanstr(excinfo)
, but there are a few cases whereexcinfo
has no methodvalue
- see in particular patches toio
andtable
. Apparently some hand-crafted or derived exceptions likeFileNotFoundError
orfits.VerifyError
still return a plain string instead of anExceptionInfo
, but I could not find any hints in the pytest docs how to properly declare exception classes to better handle this.Also
excinfo.value
does not contain the exception name, but since this is generally checked against immediately before, I think it can be safely omitted from the string comparison.On the plus side,
ExceptionInfo
provides its ownmatch
method, simplifying somere
comparisons (cf.test_html.py
andtest_wcsprm.py
).Tested with pytest 5.0.0 on Python 3.5 and 3.8; 4 unrelated
visualisation.wcsaxes
failures that turn up identically with pytest 3.10.1.