Ensure that MaskedColumn.data returns a plain MaskedArray. #8855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #8855 +/- ##
=========================================
+ Coverage 86.59% 86.99% +0.4%
=========================================
Files 405 400 -5
Lines 60116 59480 -636
Branches 1100 1100
=========================================
- Hits 52056 51745 -311
+ Misses 7419 7094 -325
Partials 641 641
Continue to review full report at Codecov.
|
Previously this was instead a masked_BaseColumn, which caused a number of performance hits, e.g., because slicing would go through multiple rounds of ``__array_finalize__``. This includes a regression check for that count.
mhvk
force-pushed
the
maskedcolumn-data-property
branch
from
0272ae6
to
5f99eef
Compare
|
@taldcroft - as you're upping the performance of |
|
@mhvk - sorry for the delay, this looks great! Only thing is that the 32-bit fails look real, mostly related to Table in some way, but I can't quite connect the dots. |
|
32-bit is fortunately not connected - see #8934 |
taldcroft
approved these changes
Jun 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was instead a masked_BaseColumn, which caused a number of performance hits, e.g., because slicing would go through multiple rounds of
__array_finalize__. This PR includes a regression check for that count.fixes #6721