EXP: Test OpenAstronomy/github-actions-workflows PR 199 downstream (Coverage: Upload as separate step)

[pllim]

Description

This pull request is to test OpenAstronomy/github-actions-workflows#199 . This should never be merged.

There is now a new job called CI / tests / Upload Coverage (pull_request) .

• By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

[github-actions]

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

[github-actions]

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

[Cadair]

I suspect this isn't working correctly due to the significant loss in project coverage, and the many many indirect coverage changes. Going through the logs, this line isn't very encouraging: https://github.com/astropy/astropy/actions/runs/9010438438/job/24756918848#step:3:86

[pllim]

We just turned off project coverage for PR. Would it be useful to rebase and try again?

Also, can you please elaborate what you see in that line of the log that is not very encouraging?

Thanks.

[Cadair]

It says it only uploads one file's worth. It looks like the lack of project coverage could well be a real bug here?

[pllim]

The line you pointed to still makes no sense to me but I see what you are saying. Lemme see if I can tweak the settings so it sees both files. Good catch!

2024-05-09T00:51:15.1586956Z Found 2 artifact(s)
...
2024-05-09T00:51:19.9914280Z info - 2024-05-09 00:51:19,991 -- Found 1 coverage files to report
2024-05-09T00:51:19.9915876Z info - 2024-05-09 00:51:19,991 -- > coverage/coverage.xml

[pllim]

OK I think I figured it out, @Cadair

2024-05-17T21:02:12.1264188Z info - 2024-05-17 21:02:12,126 -- Found 2 coverage files to report
2024-05-17T21:02:12.1265408Z info - 2024-05-17 21:02:12,126 -- > coverage/coverage_py312-test-cov/coverage.xml
2024-05-17T21:02:12.1266969Z info - 2024-05-17 21:02:12,126 -- > coverage/coverage_py310-test-oldestdeps-alldeps-cov-clocale/coverage.xml