Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Pin setuptools maxversion #14027

Closed
wants to merge 1 commit into from
Closed

MNT: Pin setuptools maxversion #14027

wants to merge 1 commit into from

Conversation

pllim
Copy link
Member

@pllim pllim commented Nov 21, 2022 •
edited

Description

This pull request is to pin setuptools maxversion to workaround numpy/numpy#22623 and pypa/setuptools#3693 until a more permanent solution can be found.

Works around #14025 .

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim pllim added 🔥 Critical no-changelog-entry-needed 💤 backport-v5.0.x on-merge: backport to v5.0.x labels Nov 21, 2022
@pllim pllim added this to the v5.0.6 milestone Nov 21, 2022
@github-actions
Copy link

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim
Copy link
Member Author

pllim commented Nov 21, 2022

doctest failure is unrelated and being handled at #14028

saimn
saimn reviewed Nov 21, 2022
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@pllim
MNT: Pin setuptools maxversion
08e267f 
to workaround numpy/numpy#22623 and pypa/setuptools#3693

though I know this is ugly.
@pllim pllim force-pushed the workaround-numpy-22623-pypa-3693 branch from 9115ad1 to 08e267f Compare November 21, 2022 21:21
@pllim pllim marked this pull request as ready for review November 21, 2022 21:53
@pllim pllim closed this Nov 28, 2022
@pllim pllim deleted the workaround-numpy-22623-pypa-3693 branch November 28, 2022 22:06
@pllim
Copy link
Member Author

pllim commented Nov 28, 2022

No longer necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saimn saimn saimn left review comments

Assignees
No one assigned
Labels
🔥 Critical installation no-changelog-entry-needed 💤 backport-v5.0.x on-merge: backport to v5.0.x
Projects
None yet
Milestone
v5.0.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pllim @saimn