Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use license_files instead of deprecated license_file in setup #13924

Merged
merged 1 commit into from Oct 27, 2022

Conversation

larrybradley
Copy link
Member

@larrybradley larrybradley commented Oct 27, 2022

Description

setuptools has deprecated license_file in favor of license_files (pypa/setuptools#2620). Currently one will get this warning:
SetuptoolsDeprecationWarning: The license_file parameter is deprecated, use license_files instead.

license_files has been an option since 2019 (pypa/setuptools#1767).

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@larrybradley larrybradley added this to the v5.0.6 milestone Oct 27, 2022
@pllim pllim added the 💤 backport-v5.0.x on-merge: backport to v5.0.x label Oct 27, 2022
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pllim pllim merged commit 7cbba86 into astropy:main Oct 27, 2022
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Oct 27, 2022
@larrybradley larrybradley deleted the license-files branch October 27, 2022 21:55
pllim added a commit that referenced this pull request Oct 27, 2022
…924-on-v5.0.x

Backport PR #13924 on branch v5.0.x (Use license_files instead of deprecated license_file in setup)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants