Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow un-setting aux WCS parameters #11166

Merged
merged 1 commit into from Dec 18, 2020
Merged

Conversation

mcara
Copy link
Contributor

@mcara mcara commented Dec 14, 2020

Fixes #11041

@mcara mcara requested a review from astrofrog December 14, 2020 21:22
@github-actions github-actions bot added the wcs label Dec 14, 2020
@mcara mcara self-assigned this Dec 14, 2020
@mcara mcara added the Bug label Dec 14, 2020
@mcara mcara added this to the v4.0.5 milestone Dec 14, 2020
@mcara mcara requested a review from Cadair December 14, 2020 21:26
@pllim
Copy link
Member

pllim commented Dec 14, 2020

@astrofrog , what's up with the SAMP failures? I saw that in cron jobs too; thought they were transient but apparently not?

See #11167 ?

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mcara - can you rebase so that #11167 gets picked up and fixes the CI?

Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @mcara 🎉

@mcara
Copy link
Contributor Author

mcara commented Dec 18, 2020

Thanks for reviewing!

@mcara mcara merged commit c65e0d8 into astropy:master Dec 18, 2020
@mcara
Copy link
Contributor Author

mcara commented Dec 18, 2020

Looks good to me!

@mcara - can you rebase so that #11167 gets picked up and fixes the CI?

@astrofrog I am sorry, I forgot about this!

astrofrog pushed a commit that referenced this pull request Mar 16, 2021
Allow un-setting aux WCS parameters
eteq pushed a commit that referenced this pull request Mar 24, 2021
Allow un-setting aux WCS parameters
@eteq
Copy link
Member

eteq commented Apr 1, 2021

Something odd happened when I backported this to 4.0.x and 4.2.x in that it pulled in a bunch of unrelated changelog entries. Easy to fix, but a bit of a github mystery...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow in-place un-setting of WCS.wcs.aux
5 participants