Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net::HTTP.SOCKSProxy auth support, take 2 #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Net::HTTP.SOCKSProxy auth support, take 2 #33

wants to merge 2 commits into from

Conversation

musybite
Copy link
Collaborator

This MR is inspired by #24, but does not use thread-local variables to store username/password. This is IMO safest and cleanest way to do it.

@musybite
Fix tests
c840b8f 
internet.yandex.com html markup was changed again
@musybite
Add authentication support to Net::HTTP.SOCKSProxy
dae6100 
Inspired by #24. This version does not require thread-local variables,
everything kept inside instance and local variables.

Thanks @ojab!
@musybite musybite mentioned this pull request Mar 13, 2018
Open
technoweenie added a commit to lostisland/faraday that referenced this pull request Jun 13, 2019
@technoweenie
support socksify api introduced in astro/socksify-ruby#33
c470fca
technoweenie added a commit to technoweenie/faraday-live that referenced this pull request Jun 13, 2019
@technoweenie
use astro/socksify-ruby#33
c4a731c
@technoweenie
Copy link

Hi, I'd like to see this in a socksify release so I can use it in Faraday. I don't personally use a SOCKS proxy, but I have successfully tested it in my integration suite with Faraday and a golang socks server.

Is there any way I can help get this out?

/cc Integration test suite PR: technoweenie/faraday-live#7
/cc Faraday PR: lostisland/faraday#992

@technoweenie technoweenie mentioned this pull request Jun 13, 2019
Open
@guivinicius
Copy link

is this good to go?

@gcolson
Copy link

gcolson commented Jul 13, 2020

Same question as @guivinicius : what is preventing this PR from being merged for so long ?

@iMacTia
Copy link

iMacTia commented Oct 14, 2020

Is there anything we can do to move this forward?

@top4ek
Copy link

top4ek commented Nov 6, 2021

Is that dead?

@astro
Copy link
Owner

astro commented Mar 21, 2022

Who wants to become maintainer?

@MatzFan
Copy link
Collaborator

MatzFan commented Jun 24, 2022

@astro if you are still looking for a maintainer for socksify I'm happy to give it a go.

@astro
Copy link
Owner

astro commented Jun 24, 2022

@MatzFan Thanks. Please be kind to my baby. ;-)

@MatzFan
Copy link
Collaborator

MatzFan commented Jun 24, 2022

With 40M downloads from rubygems.org I could hardly do otherwise :-)

@astro
Copy link
Owner

astro commented Jun 25, 2022

Oh, I was not aware.

In that case I would like to read all changes before publishing to rubygems.org. Please ping me whenever you tag a release.

@MatzFan
Copy link
Collaborator

MatzFan commented Jun 25, 2022

@astro sure, will do.

@MatzFan MatzFan mentioned this pull request Jul 4, 2022
Open
@basex
Copy link

basex commented Sep 19, 2022

Can this be merged? Works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@musybite @technoweenie @guivinicius @gcolson @iMacTia @top4ek @astro @MatzFan @basex