Display download and installation completion using Reporter
#3099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Apr 17, 2024
Comment on lines
+79
to
+81
| if let Some(reporter) = self.reporter.as_ref() { | ||
| reporter.on_install_complete(); | ||
| } |
There was a problem hiding this comment.
We never called this apparently.
zanieb
commented
Apr 17, 2024
| ) | ||
| .dimmed() | ||
| ) | ||
| .unwrap(); |
There was a problem hiding this comment.
How does the progress bar implementation get around this? Do they just eat errors?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explores moving download and install summaries to the
DownloadReporterandInstallReporterinstead of writing in the command implementation manually. This is a small step towards making theuv pip installimplementation easier to re-use e.g. inuv runwith custom reporting.