Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the target deployment to main during dispatched documentation deployments #7304

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Set the target deployment to main during dispatched documentation deployments #7304

merged 1 commit into from
Sep 12, 2023

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Sep 12, 2023 •
edited

Closes #7276 by deploying to production when not triggered by a pull request.

@zanieb
Copy link
Member Author

zanieb commented Sep 12, 2023 •
edited

Testing with dispatch at https://github.com/astral-sh/ruff/actions/runs/6161239564 (using workflow from this branch and target ref of v0.0.288)

@zanieb
Copy link
Member Author

zanieb commented Sep 12, 2023 •
edited

Confirmed that this deployed to production successfully!

We got the confusing output

npx wrangler pages deploy site --project-name=ruff-docs --branch main --commit-hash ${GITHUB_SHA}
  Uploading... (728/730)
  Uploading... (729/730)
  Uploading... (730/730)
  ✨ Success! Uploaded 2 files (728 already uploaded) (1.39 sec)
  
  ✨ Deployment complete! Take a peek over at https://02459792.ruff-docs.pages.dev/
  
  Error: fatal: bad object 0181c74ed05496287668a263116ceef6a93f582a

but it worked 🤷‍♀️

Looks like a git error message?

@zanieb
Copy link
Member Author

zanieb commented Sep 12, 2023

Tracking at cloudflare/wrangler-action#169

charliermarsh
charliermarsh approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@zanieb zanieb merged commit 5d4dd3e into main Sep 12, 2023
17 checks passed
@zanieb zanieb deleted the zanie/ci-head-ref branch September 12, 2023 15:34
zanieb added a commit that referenced this pull request Oct 3, 2023
@zanieb
Fix publish of playground
a7d4476 
Same as #7304

Closes #7779
@zanieb zanieb mentioned this pull request Oct 3, 2023
Merged
zanieb added a commit that referenced this pull request Oct 3, 2023
@zanieb
Fix publish of playground (#7791)
5d49d26 
Same as #7304

Closes #7779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs build succeeds but is not published
2 participants
@zanieb @charliermarsh