Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pylint] redefined-loop-name (W2901) #3022

Merged
merged 12 commits into from
Feb 22, 2023
Merged

[pylint] redefined-loop-name (W2901) #3022

merged 12 commits into from
Feb 22, 2023

Commits on Feb 19, 2023

  1. [pylint] redefined-loop-name (W2901) 

    Slightly broadens W2901 to cover `with` statements too.

Closes #2972.
    @matthewlloyd
    matthewlloyd committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    9923004 View commit details
    Browse the repository at this point in the history

  2. [docs] redefined-loop-name

    @matthewlloyd
    matthewlloyd committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    4c77a42 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into pylint-redefined-loop-name

    @matthewlloyd
    matthewlloyd committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    76ea0eb View commit details
    Browse the repository at this point in the history

  4. Address review comments

    @matthewlloyd
    matthewlloyd committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    b89639b View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'matthewlloyd/pylint-redefined-loop-name… 

    …' into pylint-redefined-loop-name
    @matthewlloyd
    matthewlloyd committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    b1b40c1 View commit details
    Browse the repository at this point in the history

  6. Address review comments: narrow the error message 

    Examples:

```
test.py:2:9: PLW2901 Outer for loop variable `i` overwritten by for loop target with same name
test.py:6:9: PLW2901 Outer with statement variable `i` overwritten by for loop target with same name
test.py:12:5: PLW2901 Outer for loop variable `i` overwritten by assignment target with same name
```
    @matthewlloyd
    matthewlloyd committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    1445766 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Fix broken test

    @matthewlloyd
    matthewlloyd committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    d2f0042 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Address review comments: compare target expressions structurally

    @matthewlloyd
    matthewlloyd committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    e3fcc32 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Remove redundant pattern match bindings

    @matthewlloyd
    matthewlloyd committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    7d02535 View commit details
    Browse the repository at this point in the history

  2. Wrap docstring

    @charliermarsh
    charliermarsh committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    70162e1 View commit details
    Browse the repository at this point in the history

  3. Use unparse_expr

    @charliermarsh
    charliermarsh committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    ddd2ac8 View commit details
    Browse the repository at this point in the history

  4. Tweak message

    @charliermarsh
    charliermarsh committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    e577e16 View commit details
    Browse the repository at this point in the history