Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat escaped newline as valid sequence #11465

Merged
merged 1 commit into from
May 19, 2024
Merged

Treat escaped newline as valid sequence #11465

merged 1 commit into from
May 19, 2024

Conversation

charliermarsh
Copy link
Member

Summary

We weren't treating the escaped newline as a valid condition to trigger the safer fix (add an extra backslash before each invalid escape sequence).

Closes #11461.

@charliermarsh charliermarsh added the bug Something isn't working label May 19, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) May 19, 2024 03:28
@charliermarsh charliermarsh merged commit cfceb43 into main May 19, 2024
15 of 16 checks passed
@charliermarsh charliermarsh deleted the charlie/w branch May 19, 2024 03:32
@zanieb
Copy link
Member

zanieb commented May 19, 2024

Nice!

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

commaai/openpilot (error)

Failed to clone commaai/openpilot: fatal: active `post-checkout` hook found during `git clone`:
	/home/runner/work/ruff/ruff/checkouts/commaai:openpilot/.git/hooks/post-checkout
For security reasons, this is disallowed by default.
If this is intentional and the hook should actually be run, please
run the command again with `GIT_CLONE_PROTECTION_ACTIVE=false`
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

W605 fix is unsafe
2 participants