Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example from tab-indentation #11462

Merged
merged 1 commit into from
May 17, 2024
Merged

Remove example from tab-indentation #11462

merged 1 commit into from
May 17, 2024

Conversation

charliermarsh
Copy link
Member

Summary

I think the example is more confusing than helpful, since there's no visual difference between the tab and space here (even if it rendered properly).

Closes #11460 (comment).

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label May 17, 2024
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

commaai/openpilot (error)

Failed to clone commaai/openpilot: fatal: active `post-checkout` hook found during `git clone`:
	/home/runner/work/ruff/ruff/checkouts/commaai:openpilot/.git/hooks/post-checkout
For security reasons, this is disallowed by default.
If this is intentional and the hook should actually be run, please
run the command again with `GIT_CLONE_PROTECTION_ACTIVE=false`
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

commaai/openpilot (error)

Failed to commit: Author identity unknown

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <runner@fv-az1200-840.e1fplksw42iexmyiu2m33ibpoe.ex.internal.cloudapp.net>) not allowed

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

commaai/openpilot (error)

ruff format --preview

Failed to commit: Author identity unknown

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <runner@fv-az1200-840.e1fplksw42iexmyiu2m33ibpoe.ex.internal.cloudapp.net>) not allowed

@charliermarsh charliermarsh merged commit 24899ef into main May 17, 2024
18 of 19 checks passed
@charliermarsh charliermarsh deleted the charlie/w branch May 17, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

W191 documentation example makes no sense
1 participant