Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8-pyi] Implement PYI059 (generic-not-last-base-class) #11233

Merged
merged 18 commits into from
May 7, 2024
Merged

[flake8-pyi] Implement PYI059 (generic-not-last-base-class) #11233

merged 18 commits into from
May 7, 2024

Commits on May 1, 2024

  1. [flake8-pyi] Implement PYI059

    @tusharsadhwani
    tusharsadhwani committed May 1, 2024
    Configuration menu
    Copy the full SHA
    51ea306 View commit details
    Browse the repository at this point in the history

  2. add negative cases to pyi test case

    @tusharsadhwani
    tusharsadhwani committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1f303fd View commit details
    Browse the repository at this point in the history

  3. improve tests to use attribute as well

    @tusharsadhwani
    tusharsadhwani committed May 1, 2024
    Configuration menu
    Copy the full SHA
    586c8d1 View commit details
    Browse the repository at this point in the history

  4. Add auto fix

    @tusharsadhwani
    tusharsadhwani committed May 1, 2024
    Configuration menu
    Copy the full SHA
    16ac12a View commit details
    Browse the repository at this point in the history

  5. clippy

    @tusharsadhwani
    tusharsadhwani committed May 1, 2024
    Configuration menu
    Copy the full SHA
    68aa934 View commit details
    Browse the repository at this point in the history

  6. Make issue non fixable if multiple generics are found in bases

    @tusharsadhwani
    tusharsadhwani committed May 1, 2024
    Configuration menu
    Copy the full SHA
    7e3a5d2 View commit details
    Browse the repository at this point in the history

  7. clippy fix

    @tusharsadhwani
    tusharsadhwani committed May 1, 2024
    Configuration menu
    Copy the full SHA
    97a9f93 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. [wip] Apply suggestions from code review 

    Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
    @tusharsadhwani @AlexWaygood
    tusharsadhwani and AlexWaygood committed May 3, 2024
    Configuration menu
    Copy the full SHA
    84a3edd View commit details
    Browse the repository at this point in the history

  2. cleanup code and add bare generic test case

    @tusharsadhwani
    tusharsadhwani committed May 3, 2024
    Configuration menu
    Copy the full SHA
    3cf3ed3 View commit details
    Browse the repository at this point in the history

  3. i thought i set a pre commit hook for clippy

    @tusharsadhwani
    tusharsadhwani committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ed30b1a View commit details
    Browse the repository at this point in the history

  4. raise diagnostic on bases list

    @tusharsadhwani
    tusharsadhwani committed May 3, 2024
    Configuration menu
    Copy the full SHA
    26df9fe View commit details
    Browse the repository at this point in the history

  5. preserve comments between the two bases

    @tusharsadhwani
    tusharsadhwani committed May 3, 2024
    Configuration menu
    Copy the full SHA
    281cf09 View commit details
    Browse the repository at this point in the history

  6. refactor to avoid some unwraps

    @tusharsadhwani
    tusharsadhwani committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2c82817 View commit details
    Browse the repository at this point in the history

  7. Update crates/ruff_linter/src/rules/flake8_pyi/rules/generic_not_last… 

    …_base_class.rs

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
    @tusharsadhwani @AlexWaygood
    tusharsadhwani and AlexWaygood committed May 3, 2024
    Configuration menu
    Copy the full SHA
    587d5a2 View commit details
    Browse the repository at this point in the history

  8. fmt

    @tusharsadhwani
    tusharsadhwani committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0b28a2e View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Remove remaining unwrap() and expect() calls in generate_fix()

    @AlexWaygood
    AlexWaygood committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6fce0fd View commit details
    Browse the repository at this point in the history

  2. use argument helpers

    @tusharsadhwani
    tusharsadhwani committed May 6, 2024
    Configuration menu
    Copy the full SHA
    fc70de6 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Small touch-ups

    @AlexWaygood
    AlexWaygood committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7750c91 View commit details
    Browse the repository at this point in the history