[red-knot] Resolve and check dependencies #11161
Conversation
| // WARNING!: It's important that this method takes `&mut self`. Without, the implementation is prone to race conditions. | ||
| // Note: This won't work with salsa because `Path` is not an ingredient. | ||
| pub fn path_to_module<Db>(db: &mut Db, path: &Path) -> Option<Module> |
There was a problem hiding this comment.
I think that's actually fine. There's no risk for deadlocks because the function only ever holds on to a single lock (and not multiple ones). Any mutations happen through resolve_module which must be idempotent. The only overhead here is that we might end up calling resolve_module unnecessary but that's fine.
we could even consider not making this method a query. Searching the root paths is cheap. I think the only place where we safe some performance is that we avoid the canoncialize call. So that's why I think it's still worth keeping the cache for now.
MichaReiser
force-pushed
the
red-knot-dependencies
branch
from
8ae5c06
to
5b9d16f
Compare
|
MichaReiser
force-pushed
the
red-knot-program-check
branch
2 times, most recently
from
aca0d3d
to
636ca68
Compare
MichaReiser
force-pushed
the
red-knot-dependencies
branch
from
5b9d16f
to
88b1a51
Compare
| // `from baz import bar` in `foo/__init__.py` should resolve to `foo/baz.py` | ||
| assert_eq!( | ||
| Some(ModuleName::new("foo.baz")), | ||
| foo_module.relative_name(&db, 0, Some("baz")) | ||
| ); |
There was a problem hiding this comment.
This one isn't right, from baz import bar is not a relative import (no dots), it's an absolute import, so this should resolve to just baz.
Either relative_import should error on level = 0 (and we should never call it that way), or it should just resolve it as an absolute import.
| // `from baz import test` in `foo/bar.py` resolves to `foo.bar.baz` | ||
| assert_eq!( | ||
| Some(ModuleName::new("foo.bar.baz")), | ||
| bar_module.relative_name(&db, 0, Some("baz")) | ||
| ); |
There was a problem hiding this comment.
this one is also wrong for the same reason mentioned above
Summary
Discover a modules dependencies and schedule them for checking.
This does not yet support native dependencies of which we don't have access to the source.
Test Plan
I created a
test.pyand ranred_knot test.py. The test.py importsmatch.py.I can see from the logs that
match.pyis correctly scheduled for checking. Cyclic dependencies work too.Red knot won't emit any diagnostics for
match.pybecause it isn't an open file.