Red Knot - Add symbol flags #11134
Merged
Red Knot - Add symbol flags #11134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carljm
reviewed
Apr 24, 2024
plredmond
force-pushed
the
red-knot_symbol-flags
branch
from
f7bc5fd
to
085df6e
Compare
|
plredmond
added a commit
that referenced
this pull request
Apr 29, 2024
plredmond
force-pushed
the
red-knot_symbol-flags
branch
from
accc1f8
to
94b9e17
Compare
plredmond
force-pushed
the
red-knot_symbol-flags
branch
from
6b297b0
to
e9f72ef
Compare
carljm
requested changes
Apr 29, 2024
…roduces them Co-authored-by: Carl Meyer <carl@astral.sh>
…hat introduces them
carljm
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Awesome!
Couple comments on the PR description:
- It says three flags are supported, but it seems like just two?
- This is more a forward-looking comment for the TODOs, but I realized from some conversation this morning that we will probably want to track both
CellVarandCellVarAssignedas separate kinds, where the former is "defined in current scope, used in at least one nested scope" and the latter is "defined in current scope, defined and marked_nonlocal in at least one nested scope", because the latter will have different implications for type checking.
That was a typo of "these". Sorry. I've added a commit for the other variant of Kind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbol.flagbitfield. Populates it from (the three renamed)add_or_update_symbol*methods.IS_DEFINEDis set in a scope where a variable is defined.IS_USEDis set in a scope where a variable is referenced. (To have both this andIS_DEFINEDwould require two separate appearances of a variable in the same scope-- one def and one use.)MARKED_GLOBALandMARKED_NONLOCALare not yet implemented. (TODO: While traversing, if you find these declarations, add these flags to the variable.)Symbol.kindfield (commented) and the data structure which will populate it:Kindwhich is an enum of freevar, cellvar, implicit_global, and implicit_local. Not yet populated. (TODO: a second pass over the scope (or the ast?) will observe theMARKED_GLOBALandMARKED_NONLOCALflags to populate this field. When that's added, we'll uncomment the field.)IS_DEFINEDandIS_USEDfields are correctly set and/or merged:add_or_update_symbolwill merge the flag arguments.x = foo, the variablefoois considered used but not defined.from bar import foo, the variablefoois considered defined but not used.