New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace config_overrides.patch_config by config_overrides.to_ruff_args #10436
base: main
Are you sure you want to change the base?
replace config_overrides.patch_config by config_overrides.to_ruff_args #10436
Conversation
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
E999 | 1 | 0 | 1 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
Sorry I lost track of this. Is it ready for review? |
It's not ready for review yet. I'll look again for a way to unset keys. Sorry to have let this PR/issue take so long. |
…nfig_in_ecosystem_checks
@zanieb I've tried to just set the value of the keys to unset to an empty string, but I don't know how to check whether this works or not. When I run the
|
if value is None: | ||
# Remove null values i.e. restore to default | ||
target.pop(names[-1], None) | ||
args.extend(["--config", f"{key} = ''"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexWaygood Here I'm trying to unset / restore to default some values.
This is the part of the PR I'm the most unsure about, do you know if that's the correct way to do it ?
Summary
Closes #10345
This PR removes the manual patch of the config by the overrides when doing the ecosystem checks, and instead uses the
--config
option.Test Plan
CI ?