Tweak Yoda condition message (#1638)

astral-sh · Jan 4, 2023 · 8da2c48 · 8da2c48
1 parent 34fec8c
commit 8da2c48
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -968,7 +968,7 @@ For more, see [flake8-simplify](https://pypi.org/project/flake8-simplify/0.19.3/
 | SIM221 | AOrNotA | Use `True` instead of `... or not ...` | 🛠 |
 | SIM222 | OrTrue | Use `True` instead of `... or True` | 🛠 |
 | SIM223 | AndFalse | Use `False` instead of `... and False` | 🛠 |
-| SIM300 | YodaConditions | Use `left == right` instead of `right == left (Yoda-conditions)` | 🛠 |
+| SIM300 | YodaConditions | Yoda conditions are discouraged, use `left == right` instead | 🛠 |
 
 ### flake8-tidy-imports (TID)
 

diff --git a/src/registry.rs b/src/registry.rs
@@ -2932,7 +2932,7 @@ impl CheckKind {
             CheckKind::OrTrue => "Use `True` instead of `... or True`".to_string(),
             CheckKind::AndFalse => "Use `False` instead of `... and False`".to_string(),
             CheckKind::YodaConditions(left, right) => {
-                format!("Use `{left} == {right}` instead of `{right} == {left} (Yoda-conditions)`")
+                format!("Yoda conditions are discouraged, use `{left} == {right}` instead")
             }
             // pyupgrade
             CheckKind::TypeOfPrimitive(primitive) => {
@@ -3901,9 +3901,9 @@ impl CheckKind {
                 Some("Remove `object` inheritance".to_string())
             }
             CheckKind::UselessYieldFixture(..) => Some("Replace `yield` with `return`".to_string()),
-            CheckKind::YodaConditions(left, right) => Some(format!(
-                "Replace with `{left} == {right}` (Yoda-conditions)`"
-            )),
+            CheckKind::YodaConditions(left, right) => {
+                Some(format!("Replace Yoda condition with `{left} == {right}`"))
+            }
             _ => None,
         }
     }